[Ffmpeg-devel] [PATCH] CRYO APC demuxer

[Michael Niedermayer]

Hi

On Sat, Apr 07, 2007 at 04:30:38PM +0300, Anssi Hannula wrote:
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Sat, Apr 07, 2007 at 03:01:38PM +0300, Anssi Hannula wrote:
> >> Hi!
> >>
> >> Attached is a patch implementing a demuxer for CRYO APC, a simple audio
> >> format using ADPCM encoding.
> > 
> > [...]
> > 
> >> Index: libavcodec/adpcm.c
> >> ===================================================================
> >> --- libavcodec/adpcm.c	(revision 8638)
> >> +++ libavcodec/adpcm.c	(working copy)
> >> @@ -603,10 +603,16 @@
> >>      }
> >>  
> >>      c->channel = 0;
> >> -    c->status[0].predictor = c->status[1].predictor = 0;
> >>      c->status[0].step_index = c->status[1].step_index = 0;
> >>      c->status[0].step = c->status[1].step = 0;
> >>  
> >> +    if (avctx->extradata && avctx->extradata_size == 2 * sizeof(int)) {
> > 
> > this check is too unspecific it could very well be triggered for other codecs
> > too
> 
> What would be the preferred way to do the check, then?

check codec_id ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070407/0386528d/attachment.pgp>