[Ffmpeg-devel] [patch] minor cleanup

Nicholas T ntung
Sat Apr 7 18:07:19 CEST 2007

okay, here's the casts with the very ugly python script I used.


On 4/7/07, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Apr 07, 2007 at 12:26:17AM -0700, Nicholas T wrote:
> > Michael N suggested some general cleanup so junk doesn't get copied
> > and pasted around. I know people hate it when multiple diffs are
> > combined, but these are such minor issues, I hope it's okay. This
> > really shouldn't break anything, though I honestly don't have time to
> > test all of the codecs.
> No, it's never OK to combine multiple diffs, much less if they add up to
> such a huge patch.  Minor issue or not, big patches are bound to have
> problems, plus you said you did not test this extensively.  Now if this
> gets applied and some problem crops up we have to dig through a
> multitude of changes to find the culprit.  No fun at all.
> Please split your patch into separate logical units.
> Diego
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanupcasts.diff
Type: text/x-patch
Size: 29474 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070407/a6d332ca/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup.py
Type: text/x-python
Size: 1403 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070407/a6d332ca/attachment.py>

More information about the ffmpeg-devel mailing list