[Ffmpeg-devel] [PATCH] fix for gray16le segfault in imgconvert

Reimar Döffinger Reimar.Doeffinger
Sat Apr 7 21:36:45 CEST 2007


Hello,
On Sat, Apr 07, 2007 at 08:53:45PM +0200, Ivo wrote:
> On Saturday 07 April 2007 19:46, Michael Niedermayer wrote:
> > On Sat, Apr 07, 2007 at 07:37:18PM +0200, Ivo wrote:
> > > On Saturday 07 April 2007 19:20, Michael Niedermayer wrote:
> > > > On Sat, Apr 07, 2007 at 07:15:38PM +0200, Ivo wrote:
> > > > > -    gray16_to_gray(dst, src + 1, width, height);
> > > > > +    AVPicture tmpsrc;
> > > > > +    memcpy(&tmpsrc, src, sizeof(AVPicture));
> > > > > +    tmpsrc.data[0]++;
> > > > > +    gray16_to_gray(dst, &tmpsrc, width, height);
> > > > >  }
> > > >
> > > > AVPicture tmpsrc= *src;
> > >
> > > Fourth try. How many more wrong things can I do in three lines of code?
> > > ;)
> >
> > ok
> 
> As I have never been officially granted SVN write-access to the ffmpeg-tree, 
> is it OK if I commit it myself?

That certainly is preferred, Michael after already has requested more
patch application monkeys to apply patches he oked ;-)
And MPlayer write access unless explicitly stated otherwise still does
include ffmpeg write access to my understanding. Of course you should be
ultra-careful before committing to a project you don't know well and the
developers don't know you too well either, but officially-oked patches
should not be a problem.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list