[Ffmpeg-devel] [patch] code-cleanup: make some function static

[Diego Biurrun]

On Fri, Apr 06, 2007 at 05:11:08PM +0300, Kostya wrote:
> On Fri, Apr 06, 2007 at 11:39:19AM +0200, Diego Biurrun wrote:
> > On Wed, Apr 04, 2007 at 04:22:40PM +0300, Kostya wrote:
> > > On Wed, Apr 04, 2007 at 01:35:30PM +0200, Stefan Huehner wrote:
> > > > 
> > > > attached makes some functions static which aren't used outside their
> > > > delcaring source file and have no prototype in a header file.
> > >  
> > > Applied my part (vc1.c)
> > 
> > Why don't you apply the whole patch instead of ripping out the hunk for
> > a single file?  It seems you consider it correct, Mans said it was
> > correct. 
> 
> I saw the patch, saw that it involved vc1, evaluated that part, considered
> it good and applied. The rest is not my code and I don't touch it (unless
> explicitly asked to do so). Also I've done it before saw Mans' reply.
> Sorry if that caused inconvenience.

It would be appreciated if the devs would have less of that attitude.
"It's not my code, I won't touch it" is a problem if all or most people
act this way...

Diego