[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

[Aurelien Jacobs]

On Sun, 8 Apr 2007 09:48:26 -0500
"John Donaghy" <johnfdonaghy at gmail.com> wrote:

> >
> > iam fine with either that is as long as it works, no seek no flush is of
> > course nicer if it mostly works
> 
> 
> Jon Elwood (who is working on DVRMSToolbox to make it use mencoder as the
> default way of converting dvr-ms files) has extensively tested this patch
> and discovered that it wasnt always possible to avoid a seek and flush
> without sync issues.
> 
> He also discovered that the probe functions sometimes return 1 rather than a
> value greater than 1 on the audio data I provide. (I would have expected
> higher values in all cases.) So this version first tries to detect the audio
> stream type by looking for a value > 1 and then, if that fails, it looks for
> a probe result of '1' to determine the stream type. It works for all Jon's
> samples.
> 
> I also had to do a url_fseek after the flush to avoid and output errors.
> 
> Let me know if all of this is acceptable.
> 
> Finally I removed the line that sets the format tag and consequently this
> will not work with the lavf demuxer in mplayer. So I will attempt to fix
> this and I'll raise a bug if I cant.
> 
> Index: mp3.c
> ===================================================================
> --- mp3.c	(revision 8646)
> +++ mp3.c	(working copy)
> @@ -244,7 +244,7 @@
>  
>  /* mp3 read */
>  
> -static int mp3_read_probe(AVProbeData *p)
> +int ff_mp3_read_probe(AVProbeData *p)

Instead of making this function non-static, you could simply
call mp3_demuxer.read_probe()

Aurel