[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

[Michael Niedermayer]

Hi

On Sun, Apr 08, 2007 at 08:17:24PM -0500, John Donaghy wrote:
[...]
> >
> >code duplication, also the max score should win not some >1 or other
> >random
> >test
> 
> 
> Both ac3_probe and mp3_read_probe often return 1. What should I do then?  -
> in all the samples tested the audio is always ac3 when both probe functions
> return 1.
> 
> actually, you should rather use read_probe() instead of this
> 
> 
> Do you mean read_probe() as it is used in av_probe_input_format2 - ie loop
> through the formats looking for ac3 and mp3 and then call read_probe thus
> avoiding the need to make the probe functions non-static?

you should call av_probe_input_format2()!


> 
> Also, just to clarify - I'm passing the concatenated raw data found in the
> audio packets to the probe functions. Is that definitely the right thing to
> do? I'm not certain that the data doesnt need to be inserted into some kind
> of container to make it suitable for consumption by the probe functions. I'd
> just like clarification that the way I'm doing it is right.

if you insert the data into a container, probe will detect the CONTAINER not
its contents!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070409/226f425b/attachment.pgp>