[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

John Donaghy johnfdonaghy
Tue Apr 10 01:41:36 CEST 2007


>
>
>
> well what will break if you remove the first check and just check at the
> end?



Probably nothing but I can test to find out. I though it was better to get
out as soon as possible because of the frame flush it has to do. If nothing
breaks do you want me to re-submit with the check only at the end? Also is
there a better way to set te ecodec_id than this:

        if (strncmp(fmt->name, "mp3", 3) == 0)
            st->codec->codec_id = CODEC_ID_MP3;
        else if (strncmp(fmt->name, "ac3", 3) == 0)
            st->codec->codec_id = CODEC_ID_AC3;

Thanks,

John

[...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> I have never wished to cater to the crowd; for what I know they do not
> approve, and what they approve I do not know. -- Epicurus
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
>




More information about the ffmpeg-devel mailing list