[Ffmpeg-devel] [PATCH/RFC] 1-7 and 9-15 bits per pixel PGM files

[Michael Niedermayer]

Hi

On Mon, Apr 09, 2007 at 11:51:16PM +0200, Baptiste Coudurier wrote:
[...]
> >now iam still not sure what exactly you are complaining about and maybe 
> >even
> >you yourself dont know that ;)
> >
> >is the names you disslike?
> 
> About some, yes
> 
> >is it the fact that some code plain doesnt work with your favorite pix_fmt?
> 
> Well, even if that is true, that would be up to me to support it ;)
> 
> >is it that native endian pix_fmt are available instead of littering the 
> >code
> >with #ifdef WORDS_BIGENDIAN ?
> 
> I might agree with that, but that is done atm is more complicated than 
> simply avoiding define's.
> 
> What I don't like:
> 
> first:
> 
> #ifdef WORDS_BIGENDIAN
> #define PIX_FMT_RGBA PIX_FMT_RGB32_1
> #define PIX_FMT_BGRA PIX_FMT_BGR32_1
> #define PIX_FMT_ARGB PIX_FMT_RGB32
> #define PIX_FMT_ABGR PIX_FMT_BGR32
> #else
> 
> 4 defines for 4 pixfmt is useless. Those can be specified correctly in 
> the code !

no they can not the code works just with them there is ONLY ONE option
and that is to move the #ifdef WORDS_BIGENDIAN into the code, removial
is NOT possible

please understand that the code (yuv2rgb and many applications using libav)
is working with native endian rgb32 and it does so because it is faster
noone will rewrite applications to be slower or more complex that is use
bytewise IO or convert non native endian to native endian ids just to get
rid a a single line you dont like!

also why dont you just remove the 4 lines and try to recompile? then start
changeing the code and send a patch which can be tested if you are so certain
this is a good idea ...


> Also RGBA is clearly better that BGR32_1 !

huh!? better in what respect, the number 3 is also better then 4
thats no argument to remove 4 from mathematics (for i hope obvious reasons)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070410/462ece65/attachment.pgp>