[Ffmpeg-devel] [PATCH] have cs_test check for sigsegv at smaller widths and sigill

Ivo ivop
Wed Apr 18 12:01:29 CEST 2007


Hi,

On Friday 13 April 2007 16:20, Michael Niedermayer wrote:
> On Fri, Apr 13, 2007 at 02:09:37PM +0200, Ivo wrote:
[..]
> > So, is the following patch ok and
> > have the person that runs cs_test run gdb afterwards and/or fix the
> > bug?
>
> i still dont understand what sense this patch has, if you found a scaler
> which segfaults, fix the segfault or provide a proper bugreport with gdb
> output (though fixing the segfault is more welcome)
> changeing cs_test.c so that it triggers the scaler to segfault after
> the patch has no sense it just breaks cs_test.c ...

How about now? The four problematic scalers are fixed and it would be nice 
to have cs_test test for small images too. The patch does not break cs_test 
anymore and it is useful for those adding new colorspaces to swscale, 
provided that they use cs_test to test them :)

--Ivo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cs_test.patch
Type: text/x-diff
Size: 490 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070418/1a0bc87d/attachment.patch>



More information about the ffmpeg-devel mailing list