[Ffmpeg-devel] [PATCH] add support for indexed 8bpp BMP files

Michael Niedermayer michaelni
Thu Apr 19 20:52:49 CEST 2007


Hi

On Thu, Apr 19, 2007 at 01:24:03PM +0200, Reimar Doeffinger wrote:
> Hello,
> On Mon, Apr 16, 2007 at 01:33:47PM +0200, lode leroy wrote:
> > >> +	    > +	    memcpy(p->data[1], pal, clrimportant*sizeof(uint32_t));
> > >likely wrong on big endian
> > 
> > I think it isn't. it's an array of R / G / B / 0 bytes
> > but I did change the sizeof(uint32_t) to "4" ...
> 
> Palette in data[1] must be in machine-endian in ffmpeg. I don't think
> it's that a good idea, but that's how it is...

and iam not against changing the format in data[1] so mplayer and ffmpeg
would use the same format ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070419/c689a7a5/attachment.pgp>



More information about the ffmpeg-devel mailing list