[Ffmpeg-devel] Changing "-vstats" option behaviour
Stefano Sabatini
stefano.sabatini-lala
Fri Apr 20 11:16:24 CEST 2007
On date Thursday 2007-04-19 21:35:51 +0200, Michael Niedermayer encoded:
> Hi
>
> On Thu, Apr 19, 2007 at 06:47:44PM +0200, Stefano Sabatini wrote:
> [...]
>
> > @@ -841,22 +841,15 @@
> > static void do_video_stats(AVFormatContext *os, AVOutputStream *ost,
> > int frame_size)
> > {
> > - static FILE *fvstats=NULL;
> [...]
> > + static FILE* fvstats=NULL;
>
> cosmetic
fixed
> [...]
> > @@ -3449,6 +3442,29 @@
> > }
> > }
> >
> > +static void opt_vstats_file (const char *arg)
> > +{
> > + /* if the vstats_filename global has been already defined */
> > + if (vstats_filename) {
> > + fprintf (stderr, "Warning: redefining the already defined vstats file from \"%s\" to \"%s\"\n",
> > + vstats_filename, arg);
> > + av_free (vstats_filename);
> > + }
>
> i think the warning is a overkill, i think its inconsistant, other
> options dont print such warnings either ...
> and the av_free() doesnt need the if()
removed the warning and the if
> > +
> > + vstats_filename=av_strdup (arg);
> > +}
> > +
> > +static void opt_vstats (void)
> > +{
> > + char filename[40];
> > + time_t today2 = time(NULL);
> > + struct tm *today = localtime(&today2);
> > +
>
> trailing whitespace
fixed
Cheers
--
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vstats_file-1.patch
Type: text/x-diff
Size: 3968 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070420/d5f43a51/attachment.patch>
More information about the ffmpeg-devel
mailing list