[Ffmpeg-devel] Three ffserver patches for review

Michael Niedermayer michaelni
Fri Apr 20 15:51:46 CEST 2007


On Fri, Apr 20, 2007 at 02:04:16PM +0200, Luca Abeni wrote:
> Hi Alex,
> Alex Beregszaszi wrote:
> [...]
> >Rejected, it must be a bug somewhere else. add_av_stream1 is basically
> >equivalent to av_new_stream in utils.c. My local tree uses av_new_stream
> >and removes duplicates.
> >
> >I guess rtp_new_av_stream should be simplified aswell.
> >
> >Attached is the patch, which is not really SVN ready, but you should get
> >the idea.
> I attach a version of your patch that actually works for me (I changed 
> the "#if 0" in "#if 1", and added the code for properly set the codec).
> With this patch applied, RTSP/RTP streaming works without crashing when 
> closing the second RTP session (it does not crash because your patch 
> does not allocate fst->priv_data).
> However,
> 1) I do not know if the libavformat/utils.c modifications are ok (others 
> will have to comment on this)

hmm, why doesnt ffserver use AVFormatContext?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070420/f25001d7/attachment.pgp>

More information about the ffmpeg-devel mailing list