[Ffmpeg-devel] PATCH Blackfin optimized byte swapping mechanism

Michael Niedermayer michaelni
Tue Apr 24 04:07:23 CEST 2007


On Mon, Apr 23, 2007 at 09:46:09PM -0400, Marc Hoffman wrote:
Content-Description: message body text
> Michael Niedermayer writes:
>  > Hi
>  > 
>  > not everyone duplicated these 2 bswap functions, ARCH_ARM does not for
>  > example
>  > 
>  > also, just because the code in svn is a mess does not mean its ok to add
>  > more mess
>  > 
> understood.
>  > and, iam rejecting patches which are messy mostly independant upon how
>  > difficult it is to implement a clean solution, so if it would require
>  > rewriting bswap.h then so be it but its not needed here, simply doing
>  > what ARCH_ARM does should work even if its not beautifull ...
>  > 
>  > if you want to cleanup bswap.h that is certainly welcome too, maybe
>  > a bswap.h which contains just the c functions under #ifndef FOOBAR16/32/64
>  > and then a bswap_arm.h, ...
> I see your point and it makes good sense and is a much simpler patch
> thanks Marc.

patch looks ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070424/016db7e7/attachment.pgp>

More information about the ffmpeg-devel mailing list