[Ffmpeg-devel] libswscale coding style

Ivo ivop
Sat Apr 28 12:38:36 CEST 2007


On Saturday 28 April 2007 02:11, Michael Niedermayer wrote:
> On Sat, Apr 28, 2007 at 01:20:17AM +0200, Diego Biurrun wrote:
> > On Fri, Apr 27, 2007 at 07:14:30PM +0200, Diego Biurrun wrote:
[..about how to restyle libswscale inline assembly..]
> > > I think I'll align them while I'm at it.  What's the preferred style?
> >
> > Let me be more specific:
> >
> > variant 1)
[..]
> >       "movd            18%1, %%mm3    \n\t"
> >       "punpckldq       21%1, %%mm3    \n\t"
> >       "pand           %%mm7, %%mm0    \n\t"
[..]
> > or variant 2)
[..]
> >       "movd           18%1,  %%mm3    \n\t"
> >       "punpckldq      21%1,  %%mm3    \n\t"
> >       "pand           %%mm7, %%mm0    \n\t"
[..]
>
> variant 1 looks better

Seconded.

--Ivo




More information about the ffmpeg-devel mailing list