[Ffmpeg-devel] [patch] h264.c, dont go beyond buffer in h264_decode_nal_unit

Michael Niedermayer michaelni
Sun Apr 29 11:11:36 CEST 2007


On Sun, Apr 29, 2007 at 10:20:42AM +0200, Mean wrote:
> Michael Niedermayer wrote:
> >Hi
> >
> >On Sat, Apr 28, 2007 at 06:24:58PM +0200, Mean wrote:
> >  
> >>Hello,
> >>
> >>      Please find attached a very small patch (oneliner) that prevent 
> >>going out of the buffer if the nal size does not fit in the buffer.
> >>      (sorry if it is another stupid one :) )
> >>    
> >
> >the change is wrong, the check 4 lines below should be fixed
> >simply silently breaking out of the loop in case of an error is wrong
> >  
> Ok, would that be better ?
> ( as $subject says, the main aim of the change is to avoid going beyond 
> buffer when decoding nal_size)

this is complicated, unneeded and totally wrong, it will print a silly
error message for every valid frame

also the  /*** MEANX ***/ is unacceptable svn takes care of this

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070429/11149adc/attachment.pgp>

More information about the ffmpeg-devel mailing list