[FFmpeg-devel] [PATCH/RFC] Ryan Martell's native mms code

[Michael Niedermayer]

Hi

On Thu, Aug 09, 2007 at 03:56:57PM +0200, Bj?rn Axelsson wrote:
> On Thu, 2007-08-09 at 14:35 +0200, Reimar D?ffinger wrote:
> > Hello,
> > On Thu, Aug 09, 2007 at 02:24:08PM +0200, Bj?rn Axelsson wrote:
> > > I have merged Ryan's native_mms work mentioned in an earlier mail with
> > > the SVN trunk, to produce an easily reviewed patch. I have tried not to
> > > change anything from Ryan's code except what was needed to make it
> > > compile.
> > > 
> > > native_mms.c is mostly and will still require substantial work until it
> > > is acceptable. It should probably also be split up into three files: one
> > > for common functions, one for tcp/udp and one for http. 
> > 
> > Actually I don't see why it needs to be a demuxer at all instead of only
> > a protocol. At least in MPlayer splitting it this way works (though
> > stream selection admittedly is ugly and possibly not suitable in this
> > way for ffmpeg).
> 
> Ryan mentions this in his original mail:
>   Using a URLProtocol instead was an option, but it doesn't support  
>   streaming by timestamp.  So instead I mirrored rtp stuff.
> 
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-January/020937.html
> 
> I believe what he is referring is that URLProtocol::url_seek() only
> seeking by byte position, while AVInputFormat::read_seek() can seek by
> both timestamp and byte position.
> This, and other functionality such as play/pause, can be solved by
> exposing a rich but specialized API from native_mms for the asf demuxer
> to use. Something like ff_mms_read_seek(), ff_mms_read_play(),
> ff_mms_read_pause() etc. It's not a very nice solution with a
> specialized interface, but it should work.

the URLProtocol API could also be extended if that is needed and can be
done cleanly

for example a url_time2pos() seems like a clean solution
a url_seek_to_time() is less nice but if we do that in the end anyway
its probably cleaner to do it with such a function than directly
calling ff_mms_seek()

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070809/acc7b198/attachment.pgp>