[FFmpeg-devel] [PATCH] Make parse_options take as argument a parse argument function

Michael Niedermayer michaelni
Fri Aug 10 20:30:28 CEST 2007


Hi

On Fri, Aug 10, 2007 at 07:54:18PM +0200, Stefano Sabatini wrote:
> Hi all.
> 
> Suggested log: 
> make cmdutils.c:parse_options take as argument a parse bare argument function.
> 
> Rationale:
> 
> * make more explicit the behaviour of the parse_options function
> 
> * no need to define anymore a function named parse_arg_file in a file
>   using cmdutils.c, a bare argument in the command line is managed by
>   the function passed to parse_options
> 
> * as a consequence of the previous point, is cleaner to include the
>   cmdutils.c module into a program which doesn't use the parse_options
>   function (no need to define an eventually empty parse_arg_file
>   function)
[...]
> Index: ffplay.c
> ===================================================================
> --- ffplay.c	(revision 10049)
> +++ ffplay.c	(working copy)
> @@ -2515,7 +2515,7 @@
>             );
>  }
>  
> -void parse_arg_file(const char *filename)
> +void opt_input_file(const char *filename)
>  {

cosmtic

the rest of the patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070810/d38b90ed/attachment.pgp>



More information about the ffmpeg-devel mailing list