[FFmpeg-devel] Dirac Golomb decoder [PATCH]

[Marco Gerards]

Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:

> Hello,
> On Tue, Aug 14, 2007 at 02:21:33PM +0200, Marco Gerards wrote:
>>  /*
>>   * exp golomb vlc stuff
>>   * Copyright (c) 2003 Michael Niedermayer <michaelni at gmx.at>
>> + * Copyright (c) 2007 Marco Gerards <marco at gnu.org>
>>   *
>>   * This file is part of FFmpeg.
>>   *
>> @@ -23,7 +24,7 @@
>>   * @file golomb.c
>>   * @brief
>>   *     exp golomb vlc stuff
>> - * @author Michael Niedermayer <michaelni at gmx.at>
>> + * @author Michael Niedermayer <michaelni at gmx.at> and Marco Gerards <marco at gnu.org>
>
> You only added two tables to that file, which almost certainly are not
> copyrightable so that is just plain wrong.

Ok.

> I personally don't think you should add them to golomb.h either, simply
> because if everyone added a copyright for contributions this size we
> would have a really long, long list in most files.
> Who wrote that code will still be recorded in the SVN log after all.

The reason why I added this is because IIRC it is required by the
(L)GPL.  IIRC for most GNU projects, such copyright notice is
(legally) required when you add more than about 7 lines.  I used this
rule of thumb here as well, not knowing how FFmpeg developers deal
with this.

Should I send in a new patch?  In that case, what would you like me to
remove?

--
Marco