[FFmpeg-devel] [PATCH] h264 bitstream filter

[Baptiste Coudurier]

Hi

Benoit Fouet wrote:
> Michael Niedermayer wrote:
>> Hi
>>
>> On Thu, Aug 30, 2007 at 05:12:09PM +0200, Benoit Fouet wrote:
>> [...]
>>   
>>> updated patch attached
>>>     
>> [...]
>>   
>>> +            bsfc->priv_data = out;
>>> +            bsfc->filter->priv_data_size = priv_data_size;
>>>     
>> bsfc->filter is shared between all instances
>> writing to it is absolutely not allowed
>>
>> please properly initalize priv_data_size to the size of your context
>> and store whatever you need in this context
>>
>>   
> 
> it's always easier after some sleep :)
> here it is, along with other modifications i thought of...
> 

In addition to Mans's comments,

> [...] 
>
> +
> +    else {
> +        AVCBSFContext *ctx = bsfc->priv_data;
> +        uint8_t unit_type = buf[4] & 0x1f;

This is not always correct, since size field length of NAL units in ISO
Media is specified in extradata (avcC) and not always 4.

I did not really read after but are you really overwriting NAL size
field with the startcode ?

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312