[FFmpeg-devel] [PATCH] Make libavformat/url_open print an error message in case of unrecognized protocol string

Michael Niedermayer michaelni
Sat Dec 1 03:57:31 CET 2007


On Thu, Nov 29, 2007 at 10:07:55AM +0100, Stefano Sabatini wrote:
[...]

> By the way, we should somehow fix the avcodec.h AVERROR_ mess.

yes ...


[...]
> Index: libavformat/avio.c
> ===================================================================
> --- libavformat/avio.c	(revision 11111)
> +++ libavformat/avio.c	(working copy)
> @@ -68,6 +68,7 @@
>              goto found;
>          up = up->next;
>      }
> +    av_log(NULL, AV_LOG_ERROR, "Unrecognized protocol string: %s\n", proto_str);
>      err = AVERROR(ENOENT);
>      goto fail;
>   found:

i dont like printing an error message in just one of several failure cases
this is inconsistant
and printing one in all is also not really nice

anyway its a very minor issue, i wont accept ugly hacks to fix it ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071201/80e7c464/attachment.pgp>



More information about the ffmpeg-devel mailing list