[FFmpeg-devel] [PATCH] simplify GET_UTF8 to use ff_log2_tab

Michael Niedermayer michaelni
Sun Dec 9 15:38:14 CET 2007

On Sun, Dec 09, 2007 at 11:09:25AM +0100, Reimar D?ffinger wrote:
> Hello,
> currently GET_UTF8 calls av_log2 which is simply overkill,
> since we only care about the lowest 8 bits.
> This may be intentional since my suggestion would be problematic
> if GET_UTF8 should become part of the public API, since ff_log2_tab
> is not public.
> A possibility would be to at least use av_log2_16bit or better add a
> public av_log2_8bit.
> Comments?

put a extern whatever ff_log2_tab; in GET_UTF8()

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071209/17d2685f/attachment.pgp>

More information about the ffmpeg-devel mailing list