[FFmpeg-devel] [PATCH 01/N] RV30/40 Decoder - Core

[Vitor Sessak]

Hi

Kostya wrote:
> On Thu, Dec 13, 2007 at 01:07:08PM +0100, Michael Niedermayer wrote:
>> On Thu, Dec 13, 2007 at 09:46:33AM +0200, Kostya wrote:
>>> On Sun, Dec 09, 2007 at 02:47:36PM +0100, Michael Niedermayer wrote:
>>> [...]
>>>>>> fill_rectangle() should be used here, yes please
>>>>>> move fill_rectangle() into a file from where it can be used, its a very
>>>>>> usefull function
>>>>> I guess it should be moved to h264.h. I will try to use it where appropriate.
>>>> i dont think it should be moved to h264.h its not h264 specific
>>> Then it's up to you to decide where place it.
>> rectangle.h would do for now
>>
>>
>>> [...]
>>>
>>> Here is a new revision which relies on fill_rectangle()
>>> (mostly for availability cache filling).
>> ok, ill wait until you took care of all review comments before reviewing
>> again
> 
> Should be taken now.

Just a nitpick:

rv34.h:

> /**
>  * common decoding functions
>  */
> int ff_rv34_get_start_offset(GetBitContext *gb, int blocks);
> int ff_rv34_decode_init(AVCodecContext *avctx);
> int ff_rv34_decode_frame(AVCodecContext *avctx, void *data, int *data_size, uint8_t *buf, int buf_size);
> int ff_rv34_decode_end(AVCodecContext *avctx);

Doxygen block?

-Vitor