[Ffmpeg-devel] [bug] flvdec demux

Michael Niedermayer michaelni
Sat Feb 3 03:18:54 CET 2007


On Fri, Feb 02, 2007 at 05:00:07PM -0800, Tom Harper wrote:
> Hi,
> So I found that size can == 1 in some circumstances and so
> av_get_packet gets passed size 0, and returns 0, which is
> valid (i.e. not an io error).  In loop a return value of 0 is just
> the continue case so this should be ok, and it works with
> my test case.  AV_ERROR_IO seems exceessive in this case.
> This is with a file encoded with MP3/lame and FLV1 by
> ffmpeg.

if ffmpeg generated that then theres a bug in ffmpeg

either way returning before initalizing the returned packet is not ok
either the zero size case is invalid in which case the next valid packet
or -EAGAIN should be returned or the packet is valid in which case it
should be returned

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070203/8c99b22e/attachment.pgp>

More information about the ffmpeg-devel mailing list