[Ffmpeg-devel] [PATCH] New grabbing interface

Michael Niedermayer michaelni
Sun Feb 4 04:07:19 CET 2007


On Wed, Jan 31, 2007 at 05:56:29PM -0200, ramiro at lisha.ufsc.br wrote:
> Hello,
> New grabbing interface, with suggestions from Michael, Mans and Michel, as
> discussed throughout this thread:
> http://news.gmane.org/find-root.php?message_id=%3c1144.
> It removes all "default grabbing". You must now specify the format and the
> input. Docs updated accordingly.
> Tested with video4linux2 and X11.

video4linux1 must be tested too
also video + audio grabing especially AV-sync must be tested (test old and new
and ensure that both are fine and that the new code doesnt cause more frames
to be droped (ffmpeg -v 9))

> X11 no longer needs "x11:". Making separate patches would be a worthless
> effort, since all changes in a first patch would be entirely removed by
> the second. Docs updated.
> I have a question regarding input_sync in ffmpeg.c:
> What does it do?, 

described by luca in his reply ...

> and why isn't it initialized to 0?

all global and static variables are initalized to 0
adding a =0 should have no effect on the resulting executable, if it does its
a bug in the compiler

> It's not used anymore
> (it was only by prepare_grab, and not by -grab), but I don't know if I
> should adapt it or remove it.

the new grab code should use it (if more then one grabing thingy is used
then it should be 1)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070204/fd39e88c/attachment.pgp>

More information about the ffmpeg-devel mailing list