[Ffmpeg-devel] cross compiling ffmpeg

Diego Biurrun diego
Mon Feb 5 13:59:15 CET 2007


On Mon, Feb 05, 2007 at 06:49:19AM -0500, Marc Hoffman wrote:
> 
> On Feb 5, 2007, at 3:57 AM, Diego Biurrun wrote:
> 
> >I don't much like the echos and we don't add our names to comments.
> >Also, you should try to hook up with the general structure of
> >configure and not hack in your own parts. There is one place where
> >we print output, there is one place where we handle options. Your
> >current patch is a quick hack that works for you but unacceptable for
> >us unless you address the above issues.
> 
> Thanks for helping me and sorry for the top posting.
> 
> I'm not sure if I understand so help me through this ok.  I made the  
> change associated with my initials and echos.  Which I agree with  
> however.  If you look at my change which is spread across the  
> configure script.  It was obvious to me that I need to:
> 
> 1. modify the help
> 3. disable the default behavior of using uname to get targetos if  
> targetos is not set

OK

> 2. insert the new argument handling
> 4. add default ignore handling to the main argument parsing loop.

Not OK.  After your patch there are two places where arguments are
handled.  This is unacceptable.

Diego





More information about the ffmpeg-devel mailing list