[Ffmpeg-devel] [PATCH] configure - simplify

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Feb 06, 2007 at 04:14:14AM -0200, ramiro at lisha.ufsc.br wrote:
>> 
>> else.diff changes occurences of "if;then <1 line> else <1 line> fi" to &&
>> and ||
>
> Will look at it later, but next time please send one mail per patch,
> this simplifies patch management for us, thanks.

And don't send patches with DOS line breaks.

>> While echoing to config.mak and $TMPH, some ifs indent 2 and others indent
>> 4. Which one is preferred?
>
> I prefer two spaces in shell scripts, but most of FFmpeg configure uses
> 4 spaces and I think Mans favors 4 spaces.  So I'm fine with 4 spaces
> and this is what it should be.

Yes, I prefer 4 spaces.  I find it easier to read.

-- 
M?ns Rullg?rd
mru at inprovide.com