[Ffmpeg-devel] [PATCH] fix av_log_set_level undefined

Luca Abeni lucabe72
Wed Feb 7 12:41:31 CET 2007


Hi Ben,

On Wed, 2007-02-07 at 12:09 +0100, Benoit Fouet wrote:
[...]
> > > If my understanding is correct, the attached patch might be a better
> > > solution.
> >
> > I prefer to using av_log_{get,set}_level() instead of using global
> > variable.
> > If want to keep them, then av_log_level should be defined as static.
> >  
> >
> > Thanks,
> > Limin
> indeed, this is fixed by latest delivery by Diego (r7868)
Well, Diego just reverted libavutil version to the previous value. When
libavutil version will be really increased, we will see this same
problem again :)

So, I think that it must be decided which solution should be used (keep
av_log_{get,set}_level() even in future libavutil versions, or directly
access av_log_level) and the corresponding patch (Limin's one or my one)
should be applied.
Note that I have no preferences; I just posted my patch because I tried
to follow what I remember from an old discussion... If I misunderstood
Michael or if I misremember something, just discard my patch.


			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !





More information about the ffmpeg-devel mailing list