[Ffmpeg-devel] [PATCH] fix av_log_set_level undefined

Baptiste Coudurier baptiste.coudurier
Wed Feb 7 12:42:58 CET 2007


Hi

Michael Niedermayer wrote:
> Hi
> 
> On Wed, Feb 07, 2007 at 06:11:40PM +0800, Limin Wang wrote:
>> Hi,
>>
>> * Luca Abeni <lucabe72 at email.it> [2007-02-07 10:55:50 +0100]:
>>
>>> Hi Guillaume,
>>>
>>> On Wed, 2007-02-07 at 10:32 +0100, Guillaume POIRIER wrote:
>>> [...]
>>>>> I think av_log_get/set_level is useful function and
>>>>> shouldn't depend on LIBAVUTIL_VERSION_INT version.
>>>>> The attached patch try to fix compile failed after
>>>>> LIBAVUTIL_VERSION_INT increased.
>>>> I confirm that this patch fixes compilation failure.
>>>>
>>>> Is it good to go Michael?
> 
> no rejected
> 
> 
>>> I am not Michael, but I seem to remember the discussion that originated
>>> the removal of av_log_{get,set}_level().
>>> I think Michael wanted to remove such functions by exporting
>>> av_log_level and directly accessing it.
>>>
>>> If my understanding is correct, the attached patch might be a better
>>> solution.
> 
> yes looks ok
> 
> 
>> I prefer to using av_log_{get,set}_level() instead of using global variable.
> 
> but besides that you prefer it, do you have any technical arguments for it?
> 

Possibility of checking incorrect values when using set maybe ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312




More information about the ffmpeg-devel mailing list