[Ffmpeg-devel] Crash with -vhook

[Michael Niedermayer]

Hi

On Wed, Feb 07, 2007 at 08:38:02PM +0100, Matthijs Douze wrote:
> I generated the patch with
> 
> svn diff ffmpeg.c > no_copy_vhook.patch
> 

> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 7868)
> +++ ffmpeg.c	(working copy)
> @@ -1524,6 +1524,10 @@
>          icodec = ist->st->codec;
>  
>          if (ost->st->stream_copy) {
> +	    if(using_vhook) {
> +	        fprintf(stderr,"codec copy and vook are incompatible (frames are not decoded)\n");
> +                exit(1);	
> +	    }		
>              /* if stream_copy is selected, no need to decode or encode */
>              codec->codec_id = icodec->codec_id;
>              codec->codec_type = icodec->codec_type;

tabs and trailing whitespace is forbidden in svn
also move this a little down into the CODEC_TYPE_VIDEO case as audio
streamcopy should work with vhook

except that the patch looks ok


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070207/082c0677/attachment.pgp>