[Ffmpeg-devel] Re: [PATCH] Remove INT64_C from "common.h"

[Alexander Chemeris]

Hello,

Sorry for self-commenting.

Could anybody review this patch? Mans may be?


-- 
Regards,
Alexander Chemeris.


On 2/11/07, Alexander Chemeris <ipse.ffmpeg at gmail.com> wrote:
> Hello,
>
> INT64_C macro is defined in <stdint.h>, according to paragraph 7.18.4.1
> of C99 standard. I belive it should be removed from "common.h" include,
> because it is system dependent. E.g. under MS Visual Studio it should
> be defined as
>
> #define INT64_C(val) val##i64
>
> However I should note, that if ffmpeg public headers will be used with C++
> compiler, then __STDC_CONSTANT_MACROS preprocessor define
> should be defined before first use of <stdint.h>, according to footnote 224
> at page 260 of C99 standard. It's your choice - define it in "common.h"
> just before <inttypes.h> include, or leave it undefined. In later case it would
> be good to add note to FAQ about this issue.
>
>
> --
> Regards,
> Alexander Chemeris.
>
>