[Ffmpeg-devel] [PATCH] ATRAC3 decoder

[Benjamin Larsson]

Michael Niedermayer wrote:
>
[...]

> the way the variables are named looks like they come straight from a
> dissassembler
> i remind you that taking disassembler output and converting that 1:1 to
> C is a copyright violation (of course i dont know if you did that or not)
> 
> codecs for ffmpeg which where based on reverse engeneered binary codecs
> MUST be real new implementations not just a per hand decompilation of the
> dissassembler output! if theres a 1:1 correspondance of functions or
> loops in the functions or of their arguments that is definitly not acceptable
> 
> ill review the remainder when you clearly say that its not a "translation"
> of a binary codec but a new implementation
> 
> [...]
> 

Well it is based on reverse engineering of a binary codec but I don't
know how close it is to the binary. It is bound to be closely related
but it's not a 1:1 match. I consider this to be a new implementation and
not a translation.

MvH
Benjamin Larsson