[Ffmpeg-devel] xprintf cleanup: wma.c

[Michel Bardiaux]

It contains 1 first dprintf

     dprintf("flags1=0x%x flags2=0x%x\n", flags1, flags2);

that is probably a relic since there are no such variables visible.

The following dprintf can easily become av_log.

The 2nd #if around the tprintf can go away since tprintf is a nop anyway 
when TRACE is not defined.

The 1st one is an #if 0 hence a question mark: keep or zorch?

tprintf itself is also a question. It uses av_log(NULL, which is bad. 
One coulddo one of the following:

* Change all tprintf to av_log(VERBOSE) (or DEBUG)

* Add a context argument to tprintf, but keep it a nop when TRACE not 
defined.

wav.c has Fabrice as initial author, but many other contributors, and no 
official maintainer.

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/