[Ffmpeg-devel] [PATCH]faq.texi missing --enable-gpl in liba52 take care ?

[Michael Niedermayer]

Hi

On Mon, Feb 19, 2007 at 05:26:51PM +0100, Dujardin Bernard wrote:
> Hi,
> @section Why does ffmpeg not decode audio in VOB files ?
> 
> The audio is AC3 (a.k.a. A/52). AC3 decoding is an optional component in 
> ffmpeg
> as the component that handles AC3 decoding (liba52) is currently 
> released under
> the GPL. If you have liba52 installed on your system, enable AC3 decoding
> with @code{./configure --enable-a52 -}. Take care: by
> enabling AC3, you automatically change the license of libavcodec from
> LGPL to GPL.
> 
> The last sentence may suggest that the configure script change 
> automatically the
> --enable-gpl option.
> 
> When I read the configure script, it die  with :
> 
> liba52 is under GPL and --enable-gpl is not specified
> 
> if disabled gpl ; then
>    die_gpl_disabled(){
>        name=$1
>        shift
>        enabled_any $@ && die "$name is under GPL and --enable-gpl is 
> not specified."
>    }
>    die_gpl_disabled "The Postprocessing code" pp
>    die_gpl_disabled "liba52"                  liba52
>    die_gpl_disabled "libxvidcore"             xvid
>    die_gpl_disabled "x264"                    x264
>    die_gpl_disabled "libdts"                  libdts
>    die_gpl_disabled "FAAD2"                   libfaad2
>    die_gpl_disabled "The X11 grabber"         x11grab
>    die_gpl_disabled "The software scaler"     swscaler
> fi
> 
> I Suggest another writing like
> 
> the GPL. If you have liba52 installed on your system, enable AC3 decoding
> with @code{./configure --enable-a52 --enable-gpl}. Take care: by
>                                                          ^^^^^^^^^^
> enabling AC3, you automatically change the license of libavcodec from
> LGPL to GPL.
> 
> Patch joined
> 
> ok to apply ?

yes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070219/3ee24d83/attachment.pgp>