[Ffmpeg-devel] [PATCH] updated LGPL AC-3 decoder

[Justin Ruggles]

Diego Biurrun wrote:
> On Sun, Feb 18, 2007 at 11:50:50PM -0500, Justin Ruggles wrote:
> 
>>Justin Ruggles wrote:
>>
>>>1) still don't have 256-point IMDCT working.  I've made it add silence
>>>   instead of loud pops though.
>>
>>I just want to share my excitement.  I finally got the 256-point
>>transform working.  Now I just have to simplify it. :)
> 
> 
> \o/
> 
> BTW, I think I did all the preparatory work for the native AC3 decoder,
> i.e. removing internal liba52, renaming the liba52 decoder etc.  Is
> something still missing or is everything ready for the new decoder to
> get dropped in?

Everything looks fine as far as preparing for the new decoder.  You did
mention about coming up with a solution for choosing between different
decoders.  Is my previous way of doing it ok for now? That is, by
appending different object files in the libavcodec Makefile depending on
whether or not liba52 is enabled.

I also have a question about applying the changes once a final patch set
is approved.  I want to make sure I have the right idea/order of things.
 Here is my best guess so far as to how to do it.

1) svn copy ac3enc.c to ac3.c, patched to remove all but bit allocation
and ac3_common_init.

2) remove common code from ac3enc.c and make necessary changes so that
it uses ac3.c.

3) split up and clean up the common bit allocation (probably 2 or more
commits in this step)

4) add header parsing to ac3.c and modify the ac3 parser to use it.

5) add the decoder


Thanks,
Justin