[Ffmpeg-devel] Network patch for MingW users

[Michael Niedermayer]

Hi

On Wed, Feb 21, 2007 at 04:10:58PM -0000, M?ns Rullg?rd wrote:
> 
> Alex Beregszaszi said:
> > Hi,
> >
> >> > av_neterrno(err) compares err to errno on unix
> >> > av_neterrno(err) compares WSAerr to WSASomething() on windows
> >>
> >> Yes, and I don't like it that way.
> >>
> >> > In case the WSAerr part irritates you, how would you solve this? Adding
> >> > a huge switch/case blob? After all you hate #ifdefs in other part of the
> >> > code, including the errno handling, thus we need to pass only unix errno
> >> > name, not windows ones.
> >>
> >> I had something like this in mind:
> >>
> >> #if SANE_SYSTEM
> >> #define ff_network_errno() errno
> >> #define FF_NETWORK_ERROR(err) err
> >> #elif WINDOWS
> >> #define ff_network_errno() WSAError()
> >> #define FF_NETWORK_ERROR(err) WSA##err
> >> #endif
> >>
> >> /* ... */
> >>
> >> if(ff_network_errno() == FF_NETWORK_ERROR(EFOO)){
> >>     deal_with_it();
> >> }
> >
> > What about ff_net_ and FF_NET_ ?
> 
> Whatever.
> 
> >> It's slightly more code, but it makes the code easier to understand without
> >> looking up the definitions of the macros.
> >
> > Can we do a short voting about this now?
> >
> > I perfectly ok with both systems.
> 
> Fine, then what is there to vote about?  

i vote for if(foobar == WHATEVER(ESOMETHING)) instead of if(barfoo(ESOMETHING))


> Besides, I'm against voting over
> design decisions.  Whoever is right should get to decide, not whoever has
> the loudest voice.

seconded but how do we know who is right? knowing who has the loudest voice
who is best at arguing or what the majority wants is easy, but knowing who is
ultimately right is very hard, if it where easy we wouldnt all have such
corrupt and incompetent governments

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070221/9579d2cc/attachment.pgp>