[Ffmpeg-devel] [PATCH 5/9] Doxygenize av_realloc_static comments

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Michael Niedermayer schreef:
> On Thu, Feb 22, 2007 at 03:43:49AM +0100, Panagiotis Issaris wrote:
>> The attached patch "doxygenizes" the comments for the 
>> av_realloc_static() function.
>>
>> avcodec.h |    7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> With friendly regards,
>> Takis
>>
> 
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index f143282..7117082 100644
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -2893,7 +2893,11 @@ void av_free_static(void);
>>  void *av_mallocz_static(unsigned int size);
>>  
>>  /**
>> - * same as above, but does realloc
>> + * Same as av_mallocz_static(), but does a realloc.
>> + *
>> + * @param[in] ptr The block of memory to reallocate.
>> + * @param[in] size The requested size.
>> + * @return Block of memory of requested size.
>>   */
>>  void *av_realloc_static(void *ptr, unsigned int size);
> 
> av_*alloc_static are internal functions they should not be in avcodec.h
> and should not have an av_ prefix
> 
> [...]
Okay, can apply the doxygenizing patch first and then prepare a separate
patch for moving it to a different file and removing the av_ prefix?

The only match on on av_*alloc_static I got was av_realloc_static:
find -name "*.[ch]" -exec grep -H "av_.*alloc_static" {} \;
./libavcodec/bitstream.c:            vlc->table =
av_realloc_static(vlc->table,
./libavcodec/utils.c:void *av_realloc_static(void *ptr, unsigned int size)
./libavcodec/avcodec.h:void *av_realloc_static(void *ptr, unsigned int
size);

Where you talking about that file only or some others too?

Where should av_realloc_static() be moved to? As it is only used in
bitstream.c, into that file with the declaration removed from avcodec.h?

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF3buo9kOxLuzz4CkRAjB2AJwJ+WB7YAJVJSBNM+TssmlV5JiCAACfdD64
un+54njRn1p9LLnkINq3HxE=
=WD/P
-----END PGP SIGNATURE-----