[Ffmpeg-devel] [PATCH] Remove INT64_C from "common.h"

Alexander Chemeris ipse.ffmpeg
Sun Feb 25 20:31:22 CET 2007


On 2/25/07, Ramiro Polla <angustia at arrozcru.no-ip.org> wrote:
> Alexander Chemeris wrote:
>
> > On 2/24/07, M?ns Rullg?rd <mans at mansr.com> wrote:
> >
> >> angustia at arrozcru.no-ip.org writes:
> >>
> >> > Quoting Alexander Chemeris <ipse.ffmpeg at gmail.com>:
> >> >
> >> >> Hello,
> >> >>
> >> >> INT64_C macro is defined in <stdint.h>, according to paragraph
> >> 7.18.4.1
> >> >> of C99 standard. I belive it should be removed from "common.h"
> >> include,
> >> >> because it is system dependent. E.g. under MS Visual Studio it should
> >> >> be defined as
> >> >>
> >> >> #define INT64_C(val) val##i64
> >> >>
> >> >
> >> > Simply ignored? I thought you people wanted the "ffmpeg only builds
> >> > with gcc" statement to be false...
> >> >
> >> > Leaving that there might "just happen to work" on systems that don't
> >> > define INT64_C.
> >>
> >> I don't mind removing it.
> >>
> > GCC does not have this macro definition?
> > Else I do not see any reasons for this patch to be rejected. Only
> > non-technical negligence. You're so inconsistent here.
> >
> Hmmm.... It hasn't been rejected. It *had* been ignored, but now I
> believe he ok'd it.

Oops.. My excuse to Mans. Misread, sorry.
I definitely have to sleep :)

-- 
Regards,
Alexander Chemeris.

SIPez LLC.
SIP VoIP, IM and Presence Consulting
http://www.SIPez.com
tel: +1 (617) 273-4000




More information about the ffmpeg-devel mailing list