[Ffmpeg-devel] [PATCH] access all bitrates for amr nb encoding

[Benoit Fouet]

Hi,

Benoit Fouet wrote:
> Hi,
>
> Michael Niedermayer wrote:
>   
>> Hi
>>   
>> well the user could then set -ab Y -vb X
>> if he says -b it means all bitrates so its logic to well set all
>> sure it changes behavior and iam not sure its the best solution but 
>> IMHO its more consistant to prefix video by v when audio is prefixed by a
>>
>>   
>>     
> in that case, i agree...
> we will need to have new options though.
> if it is ok, then a first patch could be sent, which just splits
> avctx_opts to a table of contexts, and ensure the functionning is the
> same as before...
> then we could look at adding prefixed options (and remove audio specific
> stuff such as ar, ab, ...)
>
>   
is something like the attached could suit ?
(i guess we should add things opt_default when needed)

>> and about order, well -ab X -ab Y is also depending on order
>>
>> so are -s X -i Y 
>>
>> [...]
>>   
>>   
>>     
> agreed, as i said, if we consider -b as overrider of -ab and -vb, to
> keep this example, then it is consistant...
>   
and when we change options, we'll also need to change regression tests
script too, i guess...

Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.c.patch
Type: text/x-patch
Size: 5844 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070226/cc1ae24d/attachment.bin>