[Ffmpeg-devel] [PATCH] Fix for the lol-ffplay.ogm testcase

[Luca Abeni]

Hi all,

sorry for the delay in the reply... I am still in the middle of a job switch

Michael Niedermayer wrote:
[...]
>>> So, should we try to always use the same construct in case of error?
>>> If yes, which one?
>>> In my opinion, for errors happening during the initialization phase
>>> there is not much point in using "goto fail", and I'd be for using
>>> "exit()" (of course, for errors happening during the decoding /
>>> encoding, "goto exit" is the correct thing to do).
>> What happened to this patch?
> 
> well it was hit by the mailiglist as bugtracker issue
> the exit patch looks ok
Ok; I'll check if it still applies (and fix it if it does not), and 
commit it

> about the more general question how to exit out, well calling exit where its
> ok to do so and goto fail with cleanup (flushing out data from buffers or 
> such) where exit is not ok seems like the correct thing to do ...
So, in the next days I'll check the error paths in ffmpeg.c and 
eventually submit a patch


				Thanks,
					Luca