[FFmpeg-devel] [PATCH]pes packetizer

[Diego Biurrun]

On Fri, Jun 29, 2007 at 09:36:27AM +0800, realsun wrote:
> --- pes.h	(revision 0)
> +++ pes.h	(revision 0)
> @@ -0,0 +1,159 @@
> +/*
> + * Copyright (c) 2000, 2001, 2002 Fabrice Bellard.

Who wrote this file?

Also, I'd write

  * Copyright (C) 2000-2002 Fabrice Bellard

> Property changes on: pes.h
> ___________________________________________________________________
> Name: svn:executable
>    + *

This is wrong, the header file is *not* an executable.

> --- Makefile	(revision 9447)
> +++ Makefile	(working copy)
> @@ -84,11 +84,11 @@
> -OBJS-$(CONFIG_MPEG1SYSTEM_MUXER)         += mpegenc.o
> -OBJS-$(CONFIG_MPEG1VCD_MUXER)            += mpegenc.o
> -OBJS-$(CONFIG_MPEG2DVD_MUXER)            += mpegenc.o
> -OBJS-$(CONFIG_MPEG2VOB_MUXER)            += mpegenc.o
> -OBJS-$(CONFIG_MPEG2SVCD_MUXER)           += mpegenc.o
> +OBJS-$(CONFIG_MPEG1SYSTEM_MUXER)         += mpegenc.o pesenc.o
> +OBJS-$(CONFIG_MPEG1VCD_MUXER)            += mpegenc.o pesenc.o
> +OBJS-$(CONFIG_MPEG2DVD_MUXER)            += mpegenc.o pesenc.o
> +OBJS-$(CONFIG_MPEG2VOB_MUXER)            += mpegenc.o pesenc.o
> +OBJS-$(CONFIG_MPEG2SVCD_MUXER)           += mpegenc.o pesenc.o

Please put this in proper alphabetical order.

> --- pesenc.c	(revision 9444)
> +++ pesenc.c	(working copy)

I would prefer if this could be called mpeg_pes_enc.c or similar, same
for the header file.

Diego