[FFmpeg-devel] [PATCH] odd-looking shifts in nutdec.c

Måns Rullgård mans
Sun Jul 8 03:31:03 CEST 2007


Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Sun, Jul 08, 2007 at 12:28:19AM +0100, M?ns Rullg?rd wrote:
>> Following up some gcc warnings, I came across a couple of odd-looking
>> shifts in nutdec.c.  The attached patch makes things make more sense
>> to me.
>
> iam tired but i think your shifts make no sense at all, the code before
> just ensured the 64 bit difference would fit in the 32bit return

Hmm... you are of course right.  I must be tired too.

Tired or otherwise, the whitespace around the operators in those
expressions is quite confusing.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list