[FFmpeg-devel] Killing AVFrac

[Michael Niedermayer]

Hi

On Mon, Jul 09, 2007 at 12:30:11AM +0100, M?ns Rullg?rd wrote:
[...]
> >> >> @@ -2177,7 +2175,7 @@ static int compute_pkt_fields2(AVStream *st, AVPacket *pkt){
> >> >>  
> >> >>  //    av_log(NULL, AV_LOG_DEBUG, "av_write_frame: pts2:%"PRId64" dts2:%"PRId64"\n", pkt->pts, pkt->dts);
> >> >>      st->cur_dts= pkt->dts;
> >> >> -    st->pts.val= pkt->dts;
> >> >> +    st->pts.num= pkt->dts * st->pts.den;
> >> >>  
> >> >>      /* update pts */
> >> >>      switch (st->codec->codec_type) {
> >> >
> >> > is also not what it was, that said iam not saying the code makes sense as it
> >> > is currently
> >> 
> >> Well, there is the den/2 bias thing...  What's the purpose of that
> >> anyway?
> >
> > i was also wondering about that
> > i suspect it was supposed to improve the rounding of pts.val, that is
> > make it round to nearest but maybe it had some other purpose ...
> 
> I suspected as much too, but figured asking was safer than assuming.
> 
> How do you propose we proceed to finally rid ourselves of AVFrac?  I'm
> growing tired of seeing those warnings all the time...

IMHO
figure out why theres a difference, fix that difference, remove AVFrac
and then remove the hacks needed to make the new code behave identical to
AVFrac where the orignal behavior was silly

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070709/48d96c26/attachment.pgp>