[FFmpeg-devel] [PATCH] use av_log_level for x264 log

[Benoit Fouet]

Limin Wang wrote:
> Hi,
>
>   
>>>> Loren already pointed out that removing the mapping table is not the 
>>>> correct solution; I just wanted to add that we now have an 
>>>> AV_LOG_WARNING error level, so the table can be updated accordingly.
>>>>     
>>>>         
>>> Yes, didn't notice that. Please add it.
>>>
>>>   
>>>       
>> done
>>     
>
> Thanks, so how about to use av_log_level also so that the log can be runtime
> control?
>
> -    x4->params.i_log_level = X264_LOG_DEBUG;
> +    x4->params.i_log_level = av_log_level; 
>
>   

isn't it already a runtime control ?
and doing what you propose is wrong, as already mentionned, because you
have no idea of what level you're asking to x264 doing it this way...

-- 
Ben
Purple Labs S.A.
www.purplelabs.com