[FFmpeg-devel] [PATCH] And yet some more __MINGW32__ #ifdefs...

[Reimar Döffinger]

Hello,
On Wed, Jul 11, 2007 at 02:30:29AM +0200, Alex Beregszaszi wrote:
> > Correct check for mkstemp instead of __MINGW32__.
> > 
> > I'll see what can be done for the remaining #ifdefs in ffplay.c and 
> > libavutil/internal.h later...
> > I won't check the network code yet, since (I think) Alex is working on 
> > that part.
> 
> Ok for me, also this code should be moved to libavutil (av_tempfile) or
> completely removed.

IMO the latter. A library has no business creating files, at least not
unless explicitly told so. If a file is necessary there should be a way
to pass a file handle something like that.

Greetings,
Reimar D?ffinger