[FFmpeg-devel] [PATCH] split png.c

[Uoti Urpala]

On Tue, 2007-07-17 at 14:16 +0200, Baptiste Coudurier wrote:
> Sorry but Im against this, png.h is internal header and is not meant to
> be included from any project directly. IMHO Mplayer is faulty here.

> Expect Mplayer to be broken oftenly if it keeps using internal ffmpeg
> structures, and not officially exported ones.

This problem wasn't triggered by intentional use of "internal
structures". The underlying reason could be more accurately said to be
the desire to use FFmpeg without a separate installation step.

avformat.h includes avcodec.h with '#include "avcodec.h"'. Now if
anything includes avformat.h (even for meant-to-be-exported features)
then for this to work either avcodec.h must be in the same directory as
avformat.h or the directory containing avcodec.h must be in the include
search path. In MPlayer the latter was the case, which then as an
unwanted side effect allowed inclusion of other files from the same
directory as avcodec.h. The alternative would be to make an
"installation" directory with copied/linked FFmpeg headers which could
then include each other without need for setting the include path.