[FFmpeg-devel] [PATCH] List supported video size and rate abbreviations

[Stefano Sabatini]

On date Friday 2007-06-01 21:16:25 +0200, Michael Niedermayer encoded:
> Hi
> 
> On Fri, Jun 01, 2007 at 06:13:28PM +0200, Stefano Sabatini wrote:
> [...]
> 
> > Index: ffmpeg.c
> > ===================================================================
> > --- ffmpeg.c	(revision 9165)
> > +++ ffmpeg.c	(working copy)
> > @@ -2065,12 +2065,27 @@
> >      av_log_level = atoi(arg);
> >  }
> >  
> > +static void list_video_rate_abvs(void)
> 
> what is abvs? if you mean abbreviation thats abbr (try google with both)

I agree with you, I was conforming to the abbreviation for
abbreviation (sic! ;-)) choosed in
libavformat/utils.c:{frame_abvs,AbvEntry}.

If you prefer I can use "abbr" consistently throughout the patch then
send a cosmetic patch to change frame_abvs and AbvEntry and the code
that use them accordingly, or even better send *before* the cosmetic
patch *then* this one.

[...]
> > Index: libavformat/avformat.h
> > ===================================================================
> > --- libavformat/avformat.h	(revision 9165)
> > +++ libavformat/avformat.h	(working copy)
> > @@ -883,6 +883,46 @@
> >  
> >  int match_ext(const char *filename, const char *extensions);
> >  
> > +
> > +/**
> > + * Number of supported video size and rate abbreviations supported.
> > + */
> > +extern int const video_size_rate_abv_nb;
> 
> would need a av_ or avcodec_ prefix

OK, then I prefer avcodec_ for consistency with
avcodec_video_{size,frame}_abv_string.

> and iam not completely sure if i like this implementation, somehow i
> dont ...

Cheers
-- 
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)