[FFmpeg-devel] [PATCH] Move the video size and rate abbreviations system from libavformat to libavcodec

[Stefano Sabatini]

On date Tuesday 2007-06-05 21:15:11 +0200, Michael Niedermayer encoded:
> Hi
>
[... ]
> On Sun, Jun 03, 2007 at 11:15:06AM +0200, Stefano Sabatini wrote:
> > The attached patch does as follows:
> > 
> > * moves the size and rate abbreviations system code (AbvEntry struct
> >   definition, frame_abvs array, parse_image_size and parse_frame_rate
> >   functions) from libavformat/utils.c to libavcodec/utils.c, where
> >   they seem to fit more properly.  
> > 
> >   parse_image_size and parse_frame_rate are now exported in
> >   libavcodec/avcodec.h.
> > 
> > Suggested changelog message:
> > "Moves the video size and rate abbreviations system code from
> > libavformat to libavcodec." 
> 
> the patch is probably ok (assuming it doesnt change the code and assuming
> i didnt miss any possible ABI compatibility issues)
> also maybe the minor version of lavc should be increased with the change

Hi Michael.

The patch doesn't change the code of the moved functions. For what
regards the version, which version should be changed,
LIBAVCODEC_VERSION (51.40.4 -> 51.40.5) or LIBAVFORMAT_VERSION
(51.12.1 -> 51.12.2)?

Note that this patch doesn't introduce any backward compatibility issue
with libavcodec, while that's true with libavformat (parsing functions
no more available in libavformat).

Sorry again for the many questions.

Cheers
-- 
Stefano Sabatini
Linux user number 337176 (see http://counter.li.org)