[FFmpeg-devel] foo -> libfoo changes

[Michael Niedermayer]

Hi

On Mon, Jun 11, 2007 at 04:14:20PM +0300, Ismail D?nmez wrote:
> On Monday 11 June 2007 16:12:43 Michael Niedermayer wrote:
> > Hi
> >
> > On Mon, Jun 11, 2007 at 04:26:02PM +0400, Pavlov Konstantin wrote:
> > > On Thu, Jun 07, 2007 at 07:47:16PM +0300, Ismail D?nmez wrote:
> > > > [...]
> > > >
> > > > >  @item example command line
> > > > > -ffmpeg -i input -acodec aac -ab 128kb -vcodec mpeg4 -b 1200kb -mbd 2
> > > > > -flags +4mv+trell -aic 2 -cmp 2 -subcmp 2 -s 320x180 -title X
> > > > > output.mp4 +ffmpeg -i input -acodec libfaac -ab 128kb -vcodec mpeg4
> > > > > -b 1200kb -mbd 2 -flags +4mv+trell -aic 2 -cmp 2 -subcmp 2 -s 320x180
> > > > > -title X output.mp4 @end table
> > > >
> > > > This _is_ bad. The code name is AAC not libfaac, same for mp3 there is
> > > > no codec called libmp3lame. Changes in configure script is ok but
> > > > changing codec name is a very bad idea and breaking backward
> > > > compatibility for no apparent reason.
> > >
> > > Sure it is. Strange to see such a change in the ABI breaking all the
> > > stuff linked to older ffmpeg.
> >
> > feel free to send a patch for avcodec_find_encoder_by_name() so it
> > selects libfaac/libmp3lame if no aac/mp3 is found
> 
> As seen on #ffmpeg :
> 
> <thresh> xdtv: symbol lookup error: xdtv: undefined symbol: x264_encoder
> 
> So the abi is broken not just command line.

i see no av prefix in it so i would say its not supposed to be part of the
public api, the corresponding ones in libavformat are also not in a public
header
its a mere bug that these are in avcodec.h, they shouldnt be

also they cannot be part of the public ABI as x264_encoder depends on x264
and x264 is optional

a patch to move these into allcodecs.h is welcome

iam also not strongly opposed to revert the renaming and put it back under
#if LIBAVCODEC_VERSION_INT > X
but iam not happy about this, and wont do any work related to it except
reviewing a patch

the software directly accessing x264_encoder
is doing something very broken no matter if x264_encoder is supposed to be
public or not, it just cant work ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070611/287aeb5a/attachment.pgp>