[FFmpeg-devel] [PATCH] Re: Reworking the codec lookup system

[Nicolas George]

Le tridi 23 prairial, an CCXV, Michael Niedermayer a ?crit?:
> our mpeg2 decoder can decode mpeg1 and 2, libmpeg2 can also
> and iam sure there are mpeg2 decoders which would refuse mpeg1
> and mpeg1 decoders which cant decode mpeg2

Yes, but from the user point of view, there are two encoders and two
decoders: mpeg1video_{en,de}coder and mpeg2video_{en,de}coder, the first
being flagged with CODEC_ID_MPEG1VIDEO and the second with
CODEC_ID_MPEG2VIDEO. The user does not know that they all rely on exactly
the same functions.

> also i think calling it "family" is not really clarifying anything

Probably, but I can not find a better expression.

> Name of the codec implementation

Ok.

> > +    /**
> > +     * Type of the codec: audio, video, subtitle, etc.
> > +     */
> >      enum CodecType type;
> redundant

Only if you remember that CodecType means audio/video/etc. But I do not
insist on that one, I only added it because I documented the field above and
the field below.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 185 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070611/3ea8ca75/attachment.pgp>