[FFmpeg-devel] [PATCH] fix Altivec inloop filter

Guillaume POIRIER poirierg
Sat Jun 16 23:19:41 CEST 2007

Hello folks

Please find below the description what attached patch does to fix
Altivec-accelerated inloop filter.
"From: Graham Booker
To: Guillaume POIRIER
Date: Jun 16, 2007 6:46 PM
Subject: h264 altivec loop_filter_luma

I noticed [9317] and I think I found a potential problem.  In the
h264_deblock_q1, the result of the deblock is *not* used in future
deblocks.  I changed the function to an inline function which returns
this value (it was a #define simply because it used to return the
value in place, but now that it is no longer in place, there is no
need for a #define).

I also reworked some of the stuff with the tc0 vector.  It is really a
signed value, so I treat it as such until after the >=0 check.  Then,
at that point, after being masked, it can be treated as unsigned."

I can confirm that this patch allows Alivec code to decode all my
samples with the same md5sum; now the question is: is this patch OK
like this, or should h264_deblock_q1 be left as a macro for now, and
converted to an inline function later, if needed?

Subversion has been the most pointless project ever started
  -- Linus Torvalds
-------------- next part --------------
A non-text attachment was scrubbed...
Name: luma_fix.1.diff
Type: application/octet-stream
Size: 7229 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070616/3d61f9d9/attachment.obj>

More information about the ffmpeg-devel mailing list